Walkthrough

The change modifies RestClient.request to treat an explicit agent property in restClientConfig as a custom agent, alongside existing checks for httpsAgent and httpAgent. When any of these three custom agents are present, proxy agent resolution is skipped; otherwise, per-URL proxy resolution is performed.

Changes

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Attention areas:
  • Verify the proxy agent selection logic handles all three agent properties (agent, httpsAgent, httpAgent) correctly and consistently
  • Ensure the change doesn't inadvertently break existing proxy behavior for configurations using only httpsAgent or httpAgent
  • Confirm the updated comment accurately reflects the new condition logic

Possibly related PRs

• fixed issue in request method in case if this.restClientConfig is not provided in config #237: Also modifies the condition in RestClient.request for proxy agent detection, but guards against this.restClientConfig being undefined
• EPMRPP-109127 || Manage proxy settings directly #235: Directly modifies the same proxy-agent selection logic, previously adding the foundational checks that this PR expands upon

Poem

🐰 A hop through the agents three—
Agent, HTTPS, and HTTP we see!
When custom ones come to stay,
Proxy resolution skips away!
Simplified logic, clear as can be! 🎉

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}